-
Notifications
You must be signed in to change notification settings - Fork 172
Update the LeapC client libraries and continue to support older Android XR clients using an older LeapC client. #1698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
…xamples folder, if let over from a previous plugin. Prevents being prompted to upgrade if on BiRP
…reading firmware versions for latest service. First attempt at supporting old Android XR clients
…ServiceBinder to maintain support for XR clients on Android
…id before trying to Bind. Minor meta file fixes. Improved debugging
…-and-retain-AndroidXR-compatibility
…ta Quest as of OS V76
rblenkinsopp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, my main questions are:
-
Do we want to be including the
HandTrackingServer.framework? This is needed to embed the tracking server, but we don't currently include the bindings for it, and this is normally done in the server part of the app at the moment? I'd almost be tempted to do this as a seperate package? -
Looks like Git LFS might be doing some strange behaviour, can you check the filters are correct and all files you expect to be LFS are?
| version https://git-lfs.github.com/spec/v1 | ||
| oid sha256:2d6d339acfe4991b90b9a3a68774759cc96649481529839212d0ed68c4557b97 | ||
| size 5138512 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we check tha this is correct, this is a Git LFS header, but it's wierd that it's shown, it's almost like it's been added as a Git LFS file, but not committed as one...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's weird. I'll check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hopefully that's fixed now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On the packaging of HandTrackerServer.framework, I can remove it. I'm keen otherwise to get this merged for Luke.
Packages/Tracking/Core/Runtime/Scripts/Utils/HandTrackingSourceUtility.cs
Show resolved
Hide resolved
…-and-retain-AndroidXR-compatibility
Summary
Updates the LeapC client libraries to 7.4.X, adding an iOS client too. Because the newest Android client no longer supports binding to a service (and changes permissions - e.g. camera permissions), we bundle two clients (one with a LeapCLegacy name), switching which is in use based on whether Android and XR/VR are being used or not.
Newer Android clients expect to read the device firmware version when obtaining DeviceInfo - assuming they connect to a recent service. This field has been added and set to unknown if the service is older.
Note, testing with Quest 3 and service version 6.20 appears to show hand tracking is broken. A Pico + Leap 2 showed signs of life with LeapC.
In future w.b.n. to get a 16 byte aligned 6.2 client.
Contributor Tasks
Reviewer Tasks
Related JIRA Issues
If this MR closes any JIRA issues list them below in the form
Closes PROJECT-#Pull Request Templates
Switch template by going to preview and clicking the link - note it will not work if you've made any changes to the description.
You are currently using: default.md
Note: these links work by overwriting query parameters of the current url. If the current url contains any you may want to amend the url with
&template=name.mdinstead of using the link. See query parameter docs for more information.