-
-
Notifications
You must be signed in to change notification settings - Fork 38
Add KITTI dataset YouTube video link in notebooks-data.yml
#79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Updated the YouTube link for the 'Object Detection with KITTI' notebook and corrected punctuation in the comments. Signed-off-by: Muhammad Rizwan Munawar <muhammadrizwanmunawar123@gmail.com>
|
👋 Hello @RizwanMunawar, thank you for submitting a
For more guidance, please refer to our Contributing Guide. If you have any questions, feel free to leave a comment — the team will be happy to help! 🚀🤝 |
UltralyticsAssistant
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔍 PR Review
Made with ❤️ by Ultralytics Actions
Overall this PR looks clean and consistent: the KITTI notebook now has a YouTube link wired through docs/notebooks-data.yml and correctly rendered in the README table, and the comment punctuation is improved. No functional or structural issues found; only a minor documentation wording tweak is suggested so the YAML header comment explicitly reflects that YouTube/video resources are part of the metadata.
💬 Posted 1 inline comment
Updated relevant resources in notebooks-data.yml to include 'youtube', 'documentation', and 'github'. Signed-off-by: Muhammad Rizwan Munawar <muhammadrizwanmunawar123@gmail.com>
UltralyticsAssistant
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔍 PR Review 2
Made with ❤️ by Ultralytics Actions
Overall this PR is small, focused, and looks correct: the KITTI notebook now has a YouTube link wired through docs/notebooks-data.yml and surfaced in the README table, matching the pattern used by other notebooks. The only minor improvement is to capitalize YouTube and GitHub in the updated header comment for consistency with common naming and branding elsewhere in the project.
💬 Posted 1 inline comment
Co-authored-by: Ultralytics Assistant <135830346+UltralyticsAssistant@users.noreply.github.com> Signed-off-by: Muhammad Rizwan Munawar <muhammadrizwanmunawar123@gmail.com>
UltralyticsAssistant
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔍 PR Review 3
Made with ❤️ by Ultralytics Actions
Changes look good and consistent with the existing notebooks metadata and README table patterns. The KITTI notebook now correctly includes a YouTube link in docs/notebooks-data.yml, and the README table row shows the matching YouTube badge. The updated header comment in docs/notebooks-data.yml improves clarity and better reflects the available resource types. No issues found regarding bugs, formatting, or style in the provided diff.
|
Merged – and what a great addition, thank you @RizwanMunawar!
By adding the YouTube tutorial link and clarifying the notebook metadata, you’ve made it easier for users to learn object detection with KITTI and YOLO in the way that suits them best, while also making our docs more navigable and contributor-friendly. Your attention to discoverability and consistency directly improves the experience for the next wave of learners and contributors. Really appreciate you taking the time to polish this flow and strengthen the notebooks ecosystem. |
🛠️ PR Summary
Made with ❤️ by Ultralytics Actions
🌟 Summary
Adds a YouTube tutorial link for the KITTI object detection notebook and clarifies notebook metadata docs, improving discoverability and consistency. 🎥📚
📊 Key Changes
README.mdnotebook tabledocs/notebooks-data.yml(youtubefield now set tohttps://youtu.be/NNeDlTbq9pA)docs/notebooks-data.ymlto more clearly list supported resources (blog, dataset, YouTube, documentation, GitHub, etc.).🎯 Purpose & Impact