Add code for off-line reconstruction of candidate trees #212

andidr · 2019-03-13T12:38:04Z

The new module offline_analysis allows for the reconstruction of a candidate
tree from the events of a log file for post-mortem analysis or conversion to a
different log format required by an analysis tool.

The reconstruction of the tree itself and refinement of candidate nodes from
actions on the nodes can be done incrementally and in an interleaved fashion as
log messages are processed. The general outline of this process is:

let mut tree = CandidateTree::new();
let mut actions = ThreadActionList::new();

// Iterate over all messages from the log file
for ... {
match message {
Message::Node { ... } => { tree.extend(...); }

  Message::Trace { ... } => {
    // Iterate over all events of the trace message
    for event ... {
      match event {
        Event::Kill(...) => {
          // Declare candidate as a deadend
          tree.get_node(curr_node_id).borrow_mut().declare_deadend(...);
      ...
        }

        Event::Implementation(...) => {
          // Update score
          tree.get_node(curr_node_id)
        .borrow_mut()
	.declare_implementation(...);
   	      ...
        }

        ...
      }
    }
  }

  Message::Evaluation { ... } => {
    ...
    t.get_node(..).borrow_mut().set_score(...);
  }
}

}

Elarnon

Why create an offline_analysis module containing a single tree module? I'd just put this in telamon::explorer::offline_analysis for now (this should be in explorer since it is the explorer log).

src/offline_analysis/tree.rs

Elarnon · 2019-03-13T12:56:23Z

src/offline_analysis/tree.rs

+    /// becomes the deadend time if no other thread has declared the
+    /// node as a deadend with a lower timestamp.
+    pub fn declare_deadend(&mut self, timestamp: Duration) {
+        if !self.is_deadend() || self.deadend_time.unwrap() > timestamp {


You typically want to avoid the "check if some and then unwrap()" pattern and use a single check instead; e.g.

pub fn declare_deadend(&mut self, mut timestamp: Duration) { if let Some(old_timestamp) = self.deadend_time { timestamp = cmp::min(timestamp, old_timestamp) } self.deadend_time = Some(timestamp); }

It looks a bit weird that the update then becomes unconditional.

src/offline_analysis/tree.rs

Elarnon · 2019-03-13T13:07:11Z

BTW it would be good to provide an API for creating a CandidateTree from a Message iterator. The simplest is to provide a fn parse<II>(ii: II) -> CandidateTree where II: IntoIterator<Item = Message> method on CandidateTree.

ulysseB

Nothing to add on the general idea, but a few Rust/style related changes. In particular, Rust tends to let the caller do the clone on the returned value rather than the callee.

src/offline_analysis/mod.rs

ulysseB · 2019-03-13T12:43:54Z

src/offline_analysis/tree.rs

+///! candidate tree from a log file
+use crate::explorer::choice::ActionEx as Action;
+use std::cell::RefCell;
+use std::collections::HashMap;


Use utils::Hashmap instead as this one is slow and non-deterministic.

As a counterpoint, I really don't like this because HashMap is a very standard name, and using utils::HashMap (which usually gets imported through use utils::*) is generally confusing.

As it turns out, utils::HashMap is nothing else than fnv::FnvHashMap (from the fnv crate, which telamon-utils uses), and I would be very much in favour of renaming our use of HashMap into this instead (which I think I'll actually do now).

can you use utils::FnvHashMap instead ?

src/offline_analysis/tree.rs

Elarnon · 2019-03-19T16:40:11Z

src/offline_analysis/tree.rs

+
+trait ReplaceDurationIfLower {
+    /// Set duration to d if currently undefined or if d is lower
+    fn replace_if_lower(&mut self, d: Duration);


Nit: Using a trait for this instead of a free-standing function is a bit overkill, but OK.

src/explorer/mcts.rs

src/offline_analysis/tree.rs

Elarnon

OK with me if you remove the AddAssign and Sub implementations on EdgeInde.

ulysseB

minor changes.

ulysseB · 2019-03-20T16:23:32Z

src/offline_analysis/tree.rs

+///! candidate tree from a log file
+use crate::explorer::choice::ActionEx as Action;
+use std::cell::RefCell;
+use std::collections::HashMap;


can you use utils::FnvHashMap instead ?

src/offline_analysis/tree.rs

The new module offline_analysis allows for the reconstruction of a candidate tree from the events of a log file for post-mortem analysis or conversion to a different log format required by an analysis tool. The reconstruction of the tree itself and refinement of candidate nodes from actions on the nodes can be done incrementally and in an interleaved fashion as log messages are processed. The general outline of this process is: let mut tree = CandidateTree::new(); // Iterate over all messages from the log file for ... { match message { Message::Node { ... } => { tree.extend(...); } Message::Trace { ... } => { // Iterate over all events of the trace message for event ... { match event { Event::Kill(...) => { // Declare candidate as a deadend tree.get_node(curr_node_id).declare_deadend(...); ... } Event::Implementation(...) => { // Declare candidate as implementation (fully specified candidate) tree.get_node(curr_node_id).declare_implementation(...); ... } ... } } } Message::Evaluation { ... } => { ... // Update score t.get_node(...).set_score(...); } } }

Elarnon · 2019-03-21T10:37:23Z

bors r=ulysseB, r=Elarnon

212: Add code for off-line reconstruction of candidate trees r=ulysseB,r=Elarnon a=andidr The new module offline_analysis allows for the reconstruction of a candidate tree from the events of a log file for post-mortem analysis or conversion to a different log format required by an analysis tool. The reconstruction of the tree itself and refinement of candidate nodes from actions on the nodes can be done incrementally and in an interleaved fashion as log messages are processed. The general outline of this process is: let mut tree = CandidateTree::new(); let mut actions = ThreadActionList::new(); // Iterate over all messages from the log file for ... { match message { Message::Node { ... } => { tree.extend(...); } Message::Trace { ... } => { // Iterate over all events of the trace message for event ... { match event { Event::Kill(...) => { // Declare candidate as a deadend tree.get_node(curr_node_id).borrow_mut().declare_deadend(...); ... } Event::Implementation(...) => { // Update score tree.get_node(curr_node_id) .borrow_mut() .declare_implementation(...); ... } ... } } } Message::Evaluation { ... } => { ... t.get_node(..).borrow_mut().set_score(...); } } } Co-authored-by: Andi Drebes <andi@drebesium.org>

bors · 2019-03-21T10:57:28Z

Build failed

continuous-integration/travis-ci/push

andidr · 2019-03-21T11:40:54Z

bors retry

212: Add code for off-line reconstruction of candidate trees r=ulysseB,r=Elarnon a=andidr The new module offline_analysis allows for the reconstruction of a candidate tree from the events of a log file for post-mortem analysis or conversion to a different log format required by an analysis tool. The reconstruction of the tree itself and refinement of candidate nodes from actions on the nodes can be done incrementally and in an interleaved fashion as log messages are processed. The general outline of this process is: let mut tree = CandidateTree::new(); let mut actions = ThreadActionList::new(); // Iterate over all messages from the log file for ... { match message { Message::Node { ... } => { tree.extend(...); } Message::Trace { ... } => { // Iterate over all events of the trace message for event ... { match event { Event::Kill(...) => { // Declare candidate as a deadend tree.get_node(curr_node_id).borrow_mut().declare_deadend(...); ... } Event::Implementation(...) => { // Update score tree.get_node(curr_node_id) .borrow_mut() .declare_implementation(...); ... } ... } } } Message::Evaluation { ... } => { ... t.get_node(..).borrow_mut().set_score(...); } } } Co-authored-by: Andi Drebes <andi@drebesium.org>

bors · 2019-03-21T14:08:27Z

Timed out

andidr · 2019-03-21T14:57:40Z

bors retry

212: Add code for off-line reconstruction of candidate trees r=ulysseB,r=Elarnon a=andidr The new module offline_analysis allows for the reconstruction of a candidate tree from the events of a log file for post-mortem analysis or conversion to a different log format required by an analysis tool. The reconstruction of the tree itself and refinement of candidate nodes from actions on the nodes can be done incrementally and in an interleaved fashion as log messages are processed. The general outline of this process is: let mut tree = CandidateTree::new(); let mut actions = ThreadActionList::new(); // Iterate over all messages from the log file for ... { match message { Message::Node { ... } => { tree.extend(...); } Message::Trace { ... } => { // Iterate over all events of the trace message for event ... { match event { Event::Kill(...) => { // Declare candidate as a deadend tree.get_node(curr_node_id).borrow_mut().declare_deadend(...); ... } Event::Implementation(...) => { // Update score tree.get_node(curr_node_id) .borrow_mut() .declare_implementation(...); ... } ... } } } Message::Evaluation { ... } => { ... t.get_node(..).borrow_mut().set_score(...); } } } Co-authored-by: Andi Drebes <andi@drebesium.org>

bors · 2019-03-21T16:00:50Z

Build succeeded

continuous-integration/travis-ci/push

andidr requested review from ulysseB and Elarnon March 13, 2019 12:38

Elarnon requested changes Mar 13, 2019

View reviewed changes

ulysseB requested changes Mar 13, 2019

View reviewed changes

andidr force-pushed the andi/aftermath branch 2 times, most recently from d867cdf to d233633 Compare March 19, 2019 15:35

Elarnon reviewed Mar 19, 2019

View reviewed changes

src/explorer/mcts.rs Outdated Show resolved Hide resolved

Elarnon reviewed Mar 19, 2019

View reviewed changes

src/offline_analysis/tree.rs Outdated Show resolved Hide resolved

Elarnon approved these changes Mar 19, 2019

View reviewed changes

andidr force-pushed the andi/aftermath branch from d233633 to 75a5b8b Compare March 20, 2019 10:44

ulysseB approved these changes Mar 20, 2019

View reviewed changes

andidr force-pushed the andi/aftermath branch 3 times, most recently from b45361f to 6f8a36f Compare March 20, 2019 18:12

andidr force-pushed the andi/aftermath branch from 6f8a36f to e3515a0 Compare March 21, 2019 09:58

bors bot merged commit e3515a0 into master Mar 21, 2019

bors bot deleted the andi/aftermath branch March 21, 2019 16:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add code for off-line reconstruction of candidate trees #212

Add code for off-line reconstruction of candidate trees #212

andidr commented Mar 13, 2019

Elarnon left a comment

Elarnon Mar 13, 2019

andidr Mar 14, 2019

Elarnon commented Mar 13, 2019

ulysseB left a comment

ulysseB Mar 13, 2019

Elarnon Mar 13, 2019

ulysseB Mar 20, 2019

Elarnon Mar 19, 2019

Elarnon left a comment

ulysseB left a comment

ulysseB Mar 20, 2019

Elarnon commented Mar 21, 2019

bors bot commented Mar 21, 2019

andidr commented Mar 21, 2019

bors bot commented Mar 21, 2019

andidr commented Mar 21, 2019

bors bot commented Mar 21, 2019

Add code for off-line reconstruction of candidate trees #212

Add code for off-line reconstruction of candidate trees #212

Conversation

andidr commented Mar 13, 2019

Elarnon left a comment

Choose a reason for hiding this comment

Elarnon Mar 13, 2019

Choose a reason for hiding this comment

andidr Mar 14, 2019

Choose a reason for hiding this comment

Elarnon commented Mar 13, 2019

ulysseB left a comment

Choose a reason for hiding this comment

ulysseB Mar 13, 2019

Choose a reason for hiding this comment

Elarnon Mar 13, 2019

Choose a reason for hiding this comment

ulysseB Mar 20, 2019

Choose a reason for hiding this comment

Elarnon Mar 19, 2019

Choose a reason for hiding this comment

Elarnon left a comment

Choose a reason for hiding this comment

ulysseB left a comment

Choose a reason for hiding this comment

ulysseB Mar 20, 2019

Choose a reason for hiding this comment

Elarnon commented Mar 21, 2019

bors bot commented Mar 21, 2019

Build failed

andidr commented Mar 21, 2019

bors bot commented Mar 21, 2019

Timed out

andidr commented Mar 21, 2019

bors bot commented Mar 21, 2019

Build succeeded