Skip to content

Refactor "advanced filters" (and rename to facets) #1243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Aug 15, 2023
Merged

Refactor "advanced filters" (and rename to facets) #1243

merged 10 commits into from
Aug 15, 2023

Conversation

yohanboniface
Copy link
Member

@yohanboniface yohanboniface commented Aug 2, 2023 •
edited
Loading

  • adding/removing of feature was managed directly in the control, which should not be case, this is fixed, and this is now done by the datalayer
  • instead of creating a new form element from scratch, we reuse Leaflet.FormBuilder
  • rename "advanced filters / data filter" by "Facet search"

I'd love to have a look at this with @Aurelie-Jallut, but in a later step.

@yohanboniface yohanboniface marked this pull request as draft August 2, 2023 07:31
@yohanboniface yohanboniface marked this pull request as ready for review August 2, 2023 14:06
@yohanboniface yohanboniface changed the title WIP : Filters refacto Refactor "advanced filters" (and rename to facets) Aug 8, 2023
@yohanboniface yohanboniface merged commit 0f2198b into master Aug 15, 2023
@yohanboniface yohanboniface deleted the filters-refacto branch August 15, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidbgk davidbgk davidbgk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yohanboniface @davidbgk