Skip to content

Ability to clone, delete and download all maps from user’s dashboard #1430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Feb 8, 2024
Merged

Ability to clone, delete and download all maps from user’s dashboard #1430

merged 8 commits into from
Feb 8, 2024

Conversation

davidbgk
Copy link
Contributor

No description provided.

@davidbgk davidbgk marked this pull request as draft November 24, 2023 22:05
davidbgk
davidbgk commented Nov 24, 2023
View reviewed changes
@davidbgk davidbgk force-pushed the download-all-from-dashboard branch from fef8076 to b6fc41c Compare November 24, 2023 22:41
@davidbgk davidbgk force-pushed the download-all-from-dashboard branch from b6fc41c to fd2c9c8 Compare December 8, 2023 21:10
@davidbgk
Copy link
Contributor Author

davidbgk commented Dec 8, 2023

New attempt, this time with paginated download too, it generates a download button per displayed page. At first I found it a bit confusing but now I'm used to it :)

Here with a pagination of 3 to see it in action, with 10 or more it's easier to understand!

Capture d’écran, le 2023-12-08 à 16 36 32

@yohanboniface yohanboniface mentioned this pull request Dec 15, 2023
Closed
@davidbgk davidbgk force-pushed the download-all-from-dashboard branch 2 times, most recently from c3fda45 to 0cfe0f2 Compare January 9, 2024 21:19
@davidbgk davidbgk changed the title Ability to download all maps from user’s dashboard Ability to delete and download all maps from user’s dashboard Jan 9, 2024
@davidbgk
Copy link
Contributor Author

davidbgk commented Jan 9, 2024

Current status:

Capture d’écran, le 2024-01-09 à 16 21 19

Refs #1459

@davidbgk davidbgk marked this pull request as ready for review January 9, 2024 22:42
yohanboniface
yohanboniface reviewed Jan 10, 2024
View reviewed changes
@davidbgk davidbgk force-pushed the download-all-from-dashboard branch 4 times, most recently from c11a604 to 4e64681 Compare January 13, 2024 15:45
@yohanboniface
Copy link
Member

Should we add a few tests? Like:

  • basic download
  • a owner or editor can download a private map
  • a non owner or editor cannot download a private map

@davidbgk
Copy link
Contributor Author

Should we add a few tests?

Yup, I was planning to do that today but time flies by :)

@davidbgk davidbgk force-pushed the download-all-from-dashboard branch 3 times, most recently from 1041174 to 228aed1 Compare January 16, 2024 18:41
davidbgk
davidbgk commented Jan 23, 2024
View reviewed changes
@Aurelie-Jallut
Copy link
Collaborator

I put two proposals here:
on the 1st I've grouped 2 pieces of information (who can edit and modification date in the Modification column). This is to reduce the number of columns.
image

On the 2nd :
With 2 columns Who can see and Who can edit: I find this clearer than using /.
image

@yohanboniface
Copy link
Member

yohanboniface commented Jan 30, 2024 •
edited
Loading

Request received by mail: being able to clone a map from within the dashboard.

Edit: an just now someone else from Tchap was looking at the clone actin just in the Dashboard page!

@davidbgk davidbgk force-pushed the download-all-from-dashboard branch from 228aed1 to 915f60d Compare February 6, 2024 17:58
@davidbgk davidbgk changed the title Ability to delete and download all maps from user’s dashboard Ability to clone, delete and download all maps from user’s dashboard Feb 6, 2024
@davidbgk davidbgk force-pushed the download-all-from-dashboard branch 2 times, most recently from 01f65db to c90f380 Compare February 6, 2024 19:32
@davidbgk
Copy link
Contributor Author

davidbgk commented Feb 6, 2024

Current status (without icons)

Capture d’écran, le 2024-02-06 à 14 32 42

@davidbgk davidbgk force-pushed the download-all-from-dashboard branch from c90f380 to 1c6ff13 Compare February 6, 2024 19:34
@davidbgk
Copy link
Contributor Author

davidbgk commented Feb 7, 2024

Current status:

Capture d’écran, le 2024-02-07 à 11 50 49

@davidbgk davidbgk force-pushed the download-all-from-dashboard branch from f5e2922 to 2af7705 Compare February 7, 2024 17:32
@davidbgk davidbgk force-pushed the download-all-from-dashboard branch 2 times, most recently from 4f14f7e to 6364107 Compare February 7, 2024 22:18
@davidbgk davidbgk force-pushed the download-all-from-dashboard branch from 6364107 to 1acadc7 Compare February 7, 2024 22:38
@davidbgk davidbgk merged commit afdc732 into master Feb 8, 2024
@davidbgk davidbgk deleted the download-all-from-dashboard branch February 8, 2024 14:51
@virgile-dev
Copy link

Cool ! Is it planned to have a bulk import button also ?
Could come handy for users who want to switch from one instance to another.

@davidbgk
Copy link
Contributor Author

@virgile-dev has been kicked from the room.

😛

Good idea, can you create a dedicated issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yohanboniface yohanboniface yohanboniface approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@davidbgk @yohanboniface @Aurelie-Jallut @virgile-dev