feat: add control to print the map and allow to download as image - #2866
Merged
Conversation
And move SearchControl to our modules.
Or download it as image.
reject is supposed to be catched when called
We only want to reset on cancel. When printing, it will be done after the image computation. Co-authored-by: David Larlet <david@larlet.fr>
Co-authored-by: David Larlet <david@larlet.fr>
Contributor
|
That's great! I wonder if we should put a message when exporting images given that it can take some time to generate and there is no visual feedback that there is actually something working in the background. It can be tricky to get the exact contours of the map where you want it but with a bit of try and adjust it ends up rendering the right part :) |
Co-authored-by: Yohan Boniface <yohanboniface@free.fr>
And exclude more bars. Co-authored-by: Yohan Boniface <yohanboniface@free.fr>
davidbgk
marked this pull request as ready for review
August 14, 2025 14:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #88