Update username with value from OAuth provider #754
Conversation
There was a problem hiding this comment.
I'm ok to go this way, so we finally fix the username issue (that's seem to be annoying to OSM backend maintainers), but OAuth is very tricky and in overriding a social_auth stage we make each future upgrade breakable. This can ends with big trouble.
So I'd say we should make a PR to social_auth before trying to workaround on our side, see how social_auth maintainers react, if it's fast good, if there are discussions we merge on our side but try to follow upstream fix until it's merged.
What do you think?
|
Hi @yohanboniface, I totally agree you. Before merging this PR, I will PR social_auth and see what happens. It seems that social_auth releases are less frequents lately. So my workaround can be valuable. 馃惔 |
|
So here is my PR python-social-auth/social-core#444 to social core. If i want to remove my workaround, I will need python-social-auth/social-core#348 to be merged too. |
|
@Binnette seems that PRs have been merged upstream. Want to update on our side before the release ? |
|
I don't have time to do it now. I'm busy on an other project 馃槄 https://github.com/opencovid19-fr/data/ |
Here is a fix for the issue #302 (changing username in OSM do not sync in uMap).
I tracked this problem deep down the following issues:
This issue is related to the fact that in "Python Social Auth - Core", the field "username" is protected and can not be updated. So if you change your username in OSM, GitHub, BitBucket or Twitter, it will never be synced in uMap. 馃槥
The best solution is a fix in "Python Social Auth - Core", we should allow developers to ignore those "default protected fields", i will probably make a PR to social-core.
So i made a workaround in uMap to fix this issue and it is working nicely. To do so, iI defined my own pipeline and used it instead of the default pipeline.
This PR will fix following issues: #491, #302