Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(flatglass): Add Showcase specification for Flatglass @ glasstec #39

Merged
merged 2 commits into from
Jul 14, 2022

Conversation

karstenroethig
Copy link
Member

No description provided.

Copy link
Member

@GoetzGoerisch GoetzGoerisch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Please resolve the comments inline and the Linters errors.
As a favor, please prepare 1.07.0 release.

Good to merge when green.

Specs/Flatglass.md Outdated Show resolved Hide resolved
Specs/Flatglass.md Outdated Show resolved Hide resolved
Specs/Flatglass.md Outdated Show resolved Hide resolved
@karstenroethig
Copy link
Member Author

Honestly, I don't get these lint errors

  • line length no more than 400? But it looks good on the website. Should I just insert a line break somewhere?
  • Changing "Node" to "Node.js" would just be wrong
  • Changing "website" to "site" changes the context in my opinion
  • When I change "html" to "HTML", the link doesn't work anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants