Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow dashboards to also be the "last accessed item" #12689

Merged
merged 2 commits into from Jul 13, 2022

Conversation

mattbrailsford
Copy link
Contributor

If within a section you navigate to a node and select it in the tree, but then click the section tree heading to view the section dashboard, if you then navigate away to a new section and then navigate back, it sends you back to the last node you selected, evern though the last thing you viewed in that section was the dashboard.

The PR allows dashboards to also be resolved from the navigationServices getLastAccessedItemForSection by allowing exact matches on the item link, as well as just sub paths of the section.

This way, when changing sections, Umbraco will actually send you back to the last thing you viewed in a section, rather than just "the last NODE you viewed".

@github-actions
Copy link

github-actions bot commented Jul 13, 2022

Hi there @mattbrailsford, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

Copy link
Contributor

@mikecp mikecp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @mattbrailsford ,

Thanks for this update, nice catch and quick fix 😁👍

May I maybe just ask you to use the triple "=" instead of double "=" in the link comparison? That would be great 😉

Cheers!

@mattbrailsford
Copy link
Contributor Author

@mikecp done 👍

@mikecp
Copy link
Contributor

mikecp commented Jul 13, 2022

Thanks @mattbrailsford , all set to merge then 😁

@mikecp mikecp merged commit 7d4a9ca into umbraco:v10/contrib Jul 13, 2022
Zeegaan pushed a commit that referenced this pull request Jul 20, 2022
* Allow dashboards to also be the "last accessed item"

* Use tripple =
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants