Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New 'variant permissions' features missing / not visible? #13067

Closed
creativesuspects opened this issue Sep 27, 2022 · 5 comments
Closed

New 'variant permissions' features missing / not visible? #13067

creativesuspects opened this issue Sep 27, 2022 · 5 comments

Comments

@creativesuspects
Copy link

creativesuspects commented Sep 27, 2022

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

10.2.1

Bug summary

I've just installed a clean 10.2.1 project. But I'm not seeing the culture and invariant/shared labels on properties. And when I want to edit a shared property I only see a green 'Edit' button, no '{propertyname} is shared across all languages warning'.

image

These new features were visible in the screenshots for PR #12605 in the Unboxing Umbraco 10.2 video.

Specifics

No response

Steps to reproduce

  • Install a clean 10.2.1 project without a starter kit
  • Add an additional non-default language, e.g. Dutch (Netherlands)
  • Add a document type with 'Allow vary by culture' and 'Allow as root'
  • Add a Textstring property with 'Allow vary by culture' disabled
  • Add a second Textstring property with 'Allow vary by culture' enabled
  • Add a single content node based on the document type
  • Configure Culture and Hostnames
  • Add values to the default language
  • Change Languages for 'Administrators' group, only allow the non-default language (e.g. Dutch)
  • Go to content node and edit the Dutch variant
  • No 'culture and invariant/shared labels' are being displayed, and no warning message when editing the shared property

Expected result / actual result

I would expect to see these features:

Pop over to "unlock" and edit the value. The Popover is visible when the property is hovered or has focus.
image

A label for a variant property that shows the current culture. The label is visible when the Property Editor is hovered or has focus.
image

A label for an invariant property that shows it's shared. The label is visible when the Property Editor is hovered or has focus.
image


This item has been added to our backlog AB#23092

@github-actions
Copy link

Hi there @creativesuspects!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

  • We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
  • If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
  • We'll replicate the issue to ensure that the problem is as described.
  • We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@lassefredslund lassefredslund added the state/sprint-candidate We're trying to get this in a sprint at HQ in the next few weeks label Oct 7, 2022
@madsrasmussen
Copy link
Contributor

Hi @creativesuspects

I have followed the steps in your description with fresh install, and I can't seem to replicate the issue. Do you have more details about your setup. Operating system, browser etc.?

Can I also get you to do a fresh install and try again?

popover

version

@creativesuspects
Copy link
Author

creativesuspects commented Oct 10, 2022

Hi @madsrasmussen

I've deleted all the 10.2.1 package files from C:\Users\{Username}\.nuget to make sure it's not a caching issue. And I've created a screencast of the clean installation process:

https://somup.com/c366jMvhkC

I'm on Windows 11 Pro 21H2 and I've tested this issue in the latest version of Chrome (as seen in the screencast), Firefox and Edge.

Edit: To make sure the issue is not specific to my desktop computer I've also tested this on a Surface Pro 8 running Windows 11 Pro 21H2 using Edge. The results were the same.

This is the server information for my desktop:

Server OS | Microsoft Windows 10.0.22000
Server Framework | .NET 6.0.9
Default Language | en-US
Umbraco Version | 10.2.1
Current Culture | en-US
Current UI Culture | en-US
Current Webserver | Kestrel
Models Builder Mode | InMemoryAuto
Debug Mode | True
Database Provider | System.Data.SQLite
Current Server Role | Single
Browser | Chrome 106.0.0.0
Browser OS | Win32

The Surface is running .NET 6.0.5.

@madsrasmussen
Copy link
Contributor

@creativesuspects Thanks for the detailed video. We found the difference between you tests and mine. It doesn't work when the property is on a tab but works when its in a group.

We have fixed the issue here: #13151 and it will be part of 10.3.

@creativesuspects
Copy link
Author

Awesome! I'm glad you were able to resolve the issue so swiftly.

@Zeegaan Zeegaan closed this as completed Oct 10, 2022
@Zeegaan Zeegaan added release/10.3.0 and removed state/sprint-candidate We're trying to get this in a sprint at HQ in the next few weeks labels Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants