ncRichText no longer working in v13

[prjseal]

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

13.0.0-rc1

Bug summary

Whilst testing out v13rc1 I came across this issue

In the block list, when using the ncRichText angular filter in the label for a block list item, it is not returning anything

Specifics

Label configuration using ncRichText angular filter

Doesn't show the value anymore

I think it may have been broken by this PR

915b63d

Steps to reproduce

Create a block list data type
Add a block list item to the available blocks, this item needs to have a property on it which is a rich text property.
In configuration for the block , add this to the label field, when content is the alias of the rich text field:

Rich Text: {{ content | ncRichText }}

You will see that it only returns the first part of the label like this:

Rich Text:

but it doesn't return anything for the value of the property.

If you take the | ncRichText filter off it does return the value in the label but as html which is what you would expect anyway.

Expected result / actual result

I expected the html to be returned as text in the label for a block list item but instead I got nothing.

---

This item has been added to our backlog AB#34799

[github-actions]

Hi there @prjseal!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

• We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
• If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
• We'll replicate the issue to ensure that the problem is as described.
• We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

[andr317c]

Hey!
Thanks for posting this issue! I was able to reproduce this on both the BlockListEditor and the BlockGridEditor in version 13.0.0-rc1. I tried testing it on version 12.3.1, where it was working without any issues. I will mark this issue as a sprint candidate 😄

[prjseal]

Hi @andr317c
When you work on this, please can you check the other filters too, I couldn't get the truncate one to work either, but I don't think this needs to be in a separate issue.

This cheat sheet is a good place to get the filters to check as a lot of people use it as a reference.

https://joe.gl/ombek/blog/umbraco-angularjs-filter-cheat-sheet/

Tagging @glombek so he is aware of the regression in v13.

Kind regards

Paul

[prjseal]

Hi, will you be fixing this before Umbraco 13 is released in a couple of weeks?

[andr317c]

Hey! We'll be working on this issue in our next sprint 😄

[ronaldbarendse]

@prjseal The commit you linked to (which is part of PR #15166) actually contains the fix, but that was merged after 13.0.0-rc1 and therefore only part of 13.0.0-rc2 (and up), see the release diffs: release-13.0.0-rc1...release-13.0.0-rc2#diff-54a73489aa5044a683072a1ba688498710b5750f89c4d31e865222e16c036d88.

Can you retest this using the latest RCs and report whether we actually fixed it correctly? 😄

[andr317c]

Hey again,
I tried testing this on rc3. And it seems to be working without any issues!

Since this issue is fixed I'll go ahead and close this issue. 😄

[Andrei-]

I just hit this bug in v13.5.3. Did it come back? Happens to blocks in Umbraco.NestedContent type
I didn't see this bug in a previous upgrade to v13.4.1 with block list though. Perhaps this is still affecting Umbraco.NestedContent?