Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content Template throws error when saving multiple times #2985

Closed
JeroenRoos opened this issue Sep 14, 2018 · 8 comments

Comments

Projects
None yet
6 participants
@JeroenRoos
Copy link

commented Sep 14, 2018

Saving mutliple times while adding a content template throws the following error:

Error

This doesn't happen during the first save, but only at the second or third. I first encountered this problem in an Umbraco Cloud environment. The same issue also appears in all our other Cloud projects and also locally.

We also found a workaround:
It is possible to add and edit content templates when you refresh the page just after saving. You have to do this each time you edit something in the template. Because it's not possible to save multiple times in a row.

Steps to reproduce

The step needed for reproduction are:

  • Create a new Content Template

  • Save the template once, to this point everything is going fine

  • Save again once or twice and you will see the error

You don't have to edit the content template before saving again, it will give the same error if you do.

Specifics

  • Encountered first in a Umbraco Cloud environment, but also appears local

  • Umbraco 7.11.1

  • Deploy 2.0.14

@dawoe

This comment has been minimized.

Copy link
Member

commented Sep 14, 2018

LOL...was about to create the same issue.
We had a cloud customer report this same issue this week. I haven't tried to reproduce locally yet.

Same Umbraco version

Dave

@nul800sebastiaan

This comment has been minimized.

Copy link
Member

commented Sep 18, 2018

Looks.. red!

I've marked as "Up for grabs" so that you or someone else coming along could create a pull request for it.

@ismailmayat

This comment has been minimized.

Copy link

commented Sep 20, 2018

I am going to tackle this today as part of hackathon in krakow.

@ismailmayat

This comment has been minimized.

Copy link

commented Sep 20, 2018

So with umbraco 7.13.0 running locally we cannot re create we also tried it on cloud with 7.8.3, we created new template and saved. Then saved again a couple of times all works fine?

@nul800sebastiaan

This comment has been minimized.

Copy link
Member

commented Sep 20, 2018

@ismailmayat It's a content template (aka blueprint), not a normal template. This caught me out when I first saw this issue, maybe that's your problem too?

@ismailmayat

This comment has been minimized.

Copy link

commented Sep 20, 2018

On the initial create you have a model that is compatible with ContentController.PostSaveBlueprint after save after initial create you have model that is compatible however on subsequent save the model is no longer compatible and hence you get a page not found.

I did some experimenting and in postsave I copied what initial create does see commit ismailmayat@500c673 that fixes the problem but only for existing items not newly created items.

@kjac

This comment has been minimized.

Copy link
Contributor

commented Oct 12, 2018

I've got a solution for this, PR incoming.

kjac added a commit to kjac/Umbraco-CMS that referenced this issue Oct 12, 2018

umbracoci pushed a commit that referenced this issue Oct 21, 2018

@Nicholas-Westby

This comment has been minimized.

Copy link
Contributor

commented Dec 15, 2018

Was about to recreate this issue too (I am getting this on 7.12.4 on Umbraco Cloud). Since I'm here, I'll just note the old ticket for this issue: https://issues.umbraco.org/issue/U4-10508

Awesome to see that it appears this will be fixed in 7.13.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.