New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RelatedLinks2 validation in Nested content #2989

Closed
zaplvlad opened this Issue Sep 17, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@zaplvlad
Copy link

zaplvlad commented Sep 17, 2018

User is able to save Nested content item without specifying required RelatedLinks2 property.

Reproduction

Steps to reproduce

  • Create a doctype which will be used in Nested content data type. Doctype contains required RelatedLinks2 property.
    image
  • Create Nested content data type and use it as property in any other doctype.
    image
  • Try to add item without filling any data in RelatedLinks2 property.
  • Press "Save an publish" button

Expected result

  • Link is required, so validation message should appears.

Actual result

  • Document is saved and published with empty link.
    image
@nul800sebastiaan

This comment has been minimized.

Copy link
Member

nul800sebastiaan commented Sep 18, 2018

I can reproduce in some cases, but sometimes I am able to make it trigger the validation, very strange.

image

That said, in this example it was empty for item 1, 2, 3 AND 5 so it should've validated all of those.

@zaplvlad

This comment has been minimized.

Copy link

zaplvlad commented Sep 18, 2018

You will see validation message if item is collapsed (so RelatedLinks2 editor is not rendered at all)

To reproduce it try to:

  1. Create document.
  2. Add few items and do not specify link
  3. Save and publish document (you will not see validation messages)
  4. Reload page (so all created items will be collapsed)
  5. Save and publish document again (validation messages will appears)
@nul800sebastiaan

This comment has been minimized.

Copy link
Member

nul800sebastiaan commented Nov 8, 2018

Fixed in: #3578

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment