GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.
Already on GitHub?
to your account
Why is there a reference to Lecoati.uSky.Grid in the ApprovedColorPickerController?
Looks like a mistake to me.
Haha, who knows, it's been there since the inital commit. Should be removed for sure!
Looks like a mistake to me as well. It's in there since the file was created more than 4 years ago.
But Is this dialog actually used. I seems to load colors from a css file. But I can't think of where I have seen this being used in the core
It's an interesting piece of code regardless, I think I would actually prefer having a CSS file for the list of colors, rather than a datatype on its own (for portability reasons).
When I remove it, everything seems to still work. PR incoming.
Look at me, making a right mess with branches of branches. But the actual, proper PR should be there :-D
Merge pull request #3156 from jannikanker/patch-1
Lecoati CSS reference removed (issue #3147)
Fixed in #3156