Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lecoati.uSky.Grid reference in ApprovedColorPickerController #3147

Closed
LennardF1989 opened this issue Oct 4, 2018 · 6 comments

Comments

Projects
None yet
4 participants
@LennardF1989
Copy link
Contributor

commented Oct 4, 2018

Why is there a reference to Lecoati.uSky.Grid in the ApprovedColorPickerController?

assetsService.loadCss("/App_Plugins/Lecoati.uSky.Grid/lib/uSky.Grid.ApprovedColorPicker.css", $scope);

Looks like a mistake to me.

@nul800sebastiaan

This comment has been minimized.

Copy link
Member

commented Oct 4, 2018

Haha, who knows, it's been there since the inital commit. Should be removed for sure!

@dawoe

This comment has been minimized.

Copy link
Member

commented Oct 4, 2018

Hi Lennard,

Looks like a mistake to me as well. It's in there since the file was created more than 4 years ago.

But Is this dialog actually used. I seems to load colors from a css file. But I can't think of where I have seen this being used in the core

Dave

@LennardF1989

This comment has been minimized.

Copy link
Contributor Author

commented Oct 4, 2018

It's an interesting piece of code regardless, I think I would actually prefer having a CSS file for the list of colors, rather than a datatype on its own (for portability reasons).

@jannikanker

This comment has been minimized.

Copy link
Contributor

commented Oct 4, 2018

When I remove it, everything seems to still work. PR incoming.

@jannikanker jannikanker referenced this issue Oct 4, 2018

Merged

Lecoati CSS reference removed (issue #3147) #3156

2 of 2 tasks complete
@jannikanker

This comment has been minimized.

Copy link
Contributor

commented Oct 4, 2018

Look at me, making a right mess with branches of branches. But the actual, proper PR should be there :-D

nul800sebastiaan added a commit that referenced this issue Oct 8, 2018

Merge pull request #3156 from jannikanker/patch-1
Lecoati CSS reference removed (issue #3147)
@nul800sebastiaan

This comment has been minimized.

Copy link
Member

commented Oct 8, 2018

Fixed in #3156

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.