Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Squashed drop-down empty selection in template query builder #3765

Closed
RobertCopilau opened this issue Nov 26, 2018 · 6 comments

Comments

@RobertCopilau
Copy link
Member

commented Nov 26, 2018

It seems that when there is nothing selected on the dropdown, the empty selection is squashed, which looks out of place.
It would be nice to have the same height as other dropdowns that have an item selected :).
squashed empty dropdown.jpg

@kjac

This comment has been minimized.

Copy link
Contributor

commented Nov 26, 2018

@RobertCopilau must be some browser specific issue? It looks fine to me on both Chrome and Firefox:

image

@RobertCopilau

This comment has been minimized.

Copy link
Member Author

commented Nov 27, 2018

Hey @KennethJakobsen, is that the latest temp8 branch?

We recently replaced the bootstrap slider with a new one which got merged yesterday into temp8. I can see the squashing on both chrome and edge, could you check whether you have the latest temp8 and try again?

@nul800sebastiaan

This comment has been minimized.

Copy link
Member

commented Nov 27, 2018

@RobertCopilau I think you mentioned our own Kenneth instead of @kjac there! 😉

@RobertCopilau

This comment has been minimized.

Copy link
Member Author

commented Nov 27, 2018

Oops :D, my bad.

@kjac

This comment has been minimized.

Copy link
Contributor

commented Nov 27, 2018

@RobertCopilau I see the error now as well... fix is simple though, PR in #3784.

@nul800sebastiaan

This comment has been minimized.

Copy link
Member

commented Nov 27, 2018

Fixed in #3784

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.