Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doctype alias placeholder sometimes stays at Generating Alias... #4027

Closed
bjarnef opened this issue Jan 10, 2019 · 2 comments

Comments

@bjarnef
Copy link
Contributor

commented Jan 10, 2019

When creating a document type the default value of alias input placeholder text is "Enter alias...", but when the name of the document type is entered the placeholder text change to "Generating Alias...".

If you then go to the alias input and clear the generated alias, the placeholder text is still "Generating Alias...". It should only be "Generating Alias..." while entering a document type name and when document type name is empty or alias text is empty, the placeholder text should be "Enter alias...".

Tested on Umbraco v.7.12.4

image

Furthermore I think the alias input should have a max-width and maybe some truncate in "locked" mode using text-overflow: elipsis; so it doesn't overlap document type name (in case of very long alias) and/or long document type name.

Here it check for undefined, null and empty string.

if( value !== undefined && value !== "" && value !== null) {

but here it only check on null and empty string.

if(scope.alias === "" && bindWatcher === true || scope.alias === null && bindWatcher === true) {

@nul800sebastiaan

This comment has been minimized.

Copy link
Member

commented Jan 10, 2019

Nice catch! Agreed.

I've marked this as "Up for grabs" so that you or someone else coming along could create a pull request for it.

@nul800sebastiaan

This comment has been minimized.

Copy link
Member

commented Jan 13, 2019

Also cherry-picked to v7 - 2ebd7a0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.