Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V8: Rename Seperator to Separator #4060

Closed
readingdancer opened this issue Jan 14, 2019 · 2 comments

Comments

@readingdancer
Copy link
Contributor

commented Jan 14, 2019

In the source code, probably forever, there have always been some reasonably obvious typos in the names of properties, this is one of the most obvious ones and I think it would be great if it was fixed in the V8 branch before the product is in its final release, or it would end up being a breaking change in the future, which I assume is one of the reasons it has never been fixed in the past.

Reproduction

there are multiple instances of the word being miss spelt throughout the solution.

Expected result

All miss spellings should be re-named to "Separator"

I will submit a pull request shortly :)

@nul800sebastiaan

This comment has been minimized.

Copy link
Member

commented Jan 17, 2019

@readingdancer

This comment has been minimized.

Copy link
Contributor Author

commented Jan 17, 2019

Your welcome, great to see it merged in, thanks 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.