Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v8 Macro picker is broken because EntityController no longer supports dynamic post filtering #4095

Closed
Shazwazza opened this Issue Jan 16, 2019 · 1 comment

Comments

Projects
None yet
3 participants
@Shazwazza
Copy link
Member

Shazwazza commented Jan 16, 2019

Reproduction

Try to use the Macro picker in v8

Specifics

There is a couple of //fixme in the EntityController which currently throws NotImplementedException because it was relying on dynamic linq which we no longer support. This is the only place where that logic is required, so instead, we should have the macro picker use a new endpoint for it's own needs, or similar.

@bergmania

This comment has been minimized.

Copy link
Member

bergmania commented Jan 30, 2019

PR: #4210

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.