Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v8: Old password is not highlighted in validation #4678

Closed
bjarnef opened this issue Feb 20, 2019 · 8 comments · Fixed by #6274
Closed

v8: Old password is not highlighted in validation #4678

bjarnef opened this issue Feb 20, 2019 · 8 comments · Fixed by #6274

Comments

@bjarnef
Copy link
Contributor

bjarnef commented Feb 20, 2019

When opening change password in user overlay and hit "change password" with blank fields, the validation is shown for each field. However for "old password" this isn't hightlighted.

image

The control-group seems to be missing the error class, which would make the validation looks like this:

image

@bjarnef bjarnef changed the title v8: Old password not highlighted in validation v8: Old password is not highlighted in validation Feb 20, 2019
@nul800sebastiaan
Copy link
Member

I've marked this as "Up for grabs" so that you or someone else coming along could create a pull request for it.

@SoerenDeger
Copy link
Contributor

It seems there is already fixed in dev-v8 branch?

image

@Shazwazza
Copy link
Contributor

@bjarnef can you confirm?

@bjarnef
Copy link
Contributor Author

bjarnef commented Mar 26, 2019

@Shazwazza yes, it seems this has been fixed in latest changes in dev-v8 branch.

image

It is also fixes in Umbraco v8.0.1 release.

@bjarnef
Copy link
Contributor Author

bjarnef commented Mar 26, 2019

However entering a value in "old password" doesn't remove the error validation on the label, but it is removed from the field.

image

When entering a value in "new password" it does however remove the error validation on "old password" (when the length is at least the minimum required characters).

@bjarnef
Copy link
Contributor Author

bjarnef commented Mar 26, 2019

Oh, if I open the user dialog and hit "change password" with empty fields it show the validation error.

image

if I then close the dialog using the link "close" or using esc key and open the user dialog again, the validation of the form has been reset, but when now hitting "change password", it shows these validation errors.

image

So it seems, it works on init, but not necessarily on subsequent validations (maybe it has something to do with the form already is dirty, touched or similar).

@bjarnef
Copy link
Contributor Author

bjarnef commented Mar 26, 2019

I guess it has something to do for formValid() function which doesn't set the error class on subsequent validations of the form.

<div class="control-group umb-control-group" ng-class="{error: !formValid(), hidelabel:hideLabel=='true'}">

@nul800sebastiaan
Copy link
Member

Fixed in #6274

Cherry picked for 8.1.5 in 468cd96

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants