Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v8: Inconsistant spacing between umb-box and umb-group-panel elements #5094

Closed
mattbrailsford opened this issue Mar 27, 2019 · 3 comments · Fixed by #5104

Comments

@mattbrailsford
Copy link
Contributor

commented Mar 27, 2019

Currently in v8, in the content section, the page is broken up into groups using elements with a css class of umb-group-panel. These groups are spaced with 20px margin between them.

However, in other areas of the system, the editor is broken up into groups using an element with a css class of umb-box which for the most part is the same, but these groups are spaced out with 8px between them.

Apart from the fact I think these should probably be reusing the same angular component in order to be standardised, at the very least, I think these should have consistant spacing. My personal preference is 20px margin between items.

@Shazwazza

This comment has been minimized.

Copy link
Member

commented Mar 28, 2019

thanks for reporting, will mark up-for-grabs and see if someone can come along to help out on this one.

@kjac

This comment has been minimized.

Copy link
Contributor

commented Mar 28, 2019

Additionally a few places are using multiple umb-expansion-panel containers which are spaced by 16px bottom margin.

I'm compiling a list of affected UI parts, then I'll push a PR.

@kjac

This comment has been minimized.

Copy link
Contributor

commented Mar 28, 2019

PR in #5104

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.