Hide icons and use buttons instead of empty anchors in Examine dashboard

[BatJan]

Prerequisites

• I have added steps to test this contribution in the description below

Description

It's all in the title really - Some housekeeping ensuring that <a> elements with empty href attributes are replaced with <button> elements and that <i> elements are hidden using aria-hidden="true".

[nul800sebastiaan]

Nice one Jan, will have to give it a spin soon!

[nul800sebastiaan]

@BatJan Looks like this needs a bit of a styling update to the button now, can you have a look please? Note I've merged this with v8/dev and the styling might have broken due to a wrong merge on my behalf 🙈

[nul800sebastiaan]

Also note: the "Test" links in this screenshots are anchors as well, I might be wrong in merging that, they should probably be buttons as well, not sure.

[BatJan]

@nul800sebastiaan No worries, the lack of styling was an oversigt on my part. Forgot about testing the search 🤦‍♂

No the test items are proper links referencing other nodes in the backoffice - They have ng-href attribute with values in them 😉

Anything else I need to address? 😃

[nul800sebastiaan]

Nope, just the button styling! 👍

[nul800sebastiaan]

All great now, thanks @BatJan!