Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V8: Turn the "empty recycle bin" warning into an actual warning #6598

Merged

Conversation

kjac
Copy link
Contributor

@kjac kjac commented Oct 7, 2019

Prerequisites

  • I have added steps to test this contribution in the description below

Description

The "empty recycle bin" warning doesn't quite feel like much of a warning; it looks more like a confirmation dialog, despite its destructive behavior:

image

This PR updates the warning so it looks like an actual warning:

image

...and similarly for the media section:

image

@nul800sebastiaan
Copy link
Member

Looking good! We'll give it a look soon!

@nul800sebastiaan
Copy link
Member

Danger, Danger! 🎵

Good stuff, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants