Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Startup dashboard: Add view fallback translations #6884

Merged
merged 5 commits into from Jan 6, 2020
Merged

Startup dashboard: Add view fallback translations #6884

merged 5 commits into from Jan 6, 2020

Conversation

BatJan
Copy link
Contributor

@BatJan BatJan commented Oct 26, 2019

Prerequisites

  • I have added steps to test this contribution in the description below

Description

I have added some missing translations in case the fetching of the dynamic dashboard content fails and the fallback content is being shown.

Copy link
Contributor

@poornimanayar poornimanayar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey again @BatJan ,

Works as expected! 💯

@kjac kjac changed the base branch from v8/dev to v8/contrib January 6, 2020 19:07
@kjac kjac merged commit 617216e into umbraco:v8/contrib Jan 6, 2020
@kjac
Copy link
Contributor

kjac commented Jan 6, 2020

All good and merged - thank you again, @BatJan ⭐️

@kjac kjac added community/pr hacktoberfest/contrib-2019 release/8.6.0 release/no-notes This is too small to add to the release notes or fixed after a beta/RC type/feature labels Jan 6, 2020
@nul800sebastiaan nul800sebastiaan removed the release/no-notes This is too small to add to the release notes or fixed after a beta/RC label Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants