V8: Fix button style when opening doctype in infinite editing with unsaved changes #7003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h unsaved changes
|
Thanks for this @kjac! Poornima |
emmaburstow
approved these changes
Dec 3, 2019
emmaburstow
approved these changes
Dec 3, 2019
emmaburstow
added
community/pr
release/8.7.0
release/no-notes
kjac
deleted the
v8/fix/infinite-edit-doctype-warning-style-dialog-button
branch
nul800sebastiaan
removed
the
release/no-notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
The button style should probably be
warningfor the dialog that alerts you how changes will be discarded if you open the doctype in infinite editing without saving your changes first:So... this PR updates the button style: