Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Umbraco is using alias of Image Cropper to define Image URL #7279

Closed
bielu opened this issue Dec 5, 2019 · 6 comments
Closed

Umbraco is using alias of Image Cropper to define Image URL #7279

bielu opened this issue Dec 5, 2019 · 6 comments

Comments

@bielu
Copy link
Contributor

bielu commented Dec 5, 2019

Umbraco is using alias of editor in URL Provider
image (4)
This generates an issue when someone is trying to build custom ImageCropper which is using same ImageCropperValueConverter as Umbraco will return empty URL.

@rasmusjp
Copy link
Member

rasmusjp commented Dec 5, 2019

Hi @bielu

There are multiple places in the source code that assume it's only ImageCropper and Upload that stores files and have url's.

There's an open PR in #7075 that changes how this works

For now you can create your own IMediaUrlProvider that resolves the url for your property editor and add it to the media url provider collection composition.MediaUrlProviders().Insert<MyMediaUrlProvider>();.

@emmaburstow
Copy link
Contributor

Hey all,

Thanks for responding, Rasmus :) I'll close this issue as there's a community PR that addresses it.

Emma

@nul800sebastiaan
Copy link
Member

Let's keep it open, the PR will resolve this issue, at which point it can be closed! 👍

@emmaburstow
Copy link
Contributor

Thanks Seb - my mistake 🙈

@rasmusjp
Copy link
Member

@nul800sebastiaan #7075 has been merged so I think this can be closed now?

@nul800sebastiaan
Copy link
Member

Thanks @rasmusjp! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants