Property editor UI does not reflect ReadOnly property

[harry-gordon]

Setting ReadOnly to true on ContentPropertyDisplay does not make the associated UI read-only. For example, on the editor SendingContentModel event I'm setting a property as read only but the property editor is not disabled. This seems to be the case with all common property editors.

This behaviour seems counter-intuitive and incomplete so I'm filing it as a bug.

Umbraco version

I am seeing this issue on Umbraco version: 8.6 (but the implementation seems the same in 7.x)

Reproduction

Bug summary

Setting ReadOnly to true on ContentPropertyDisplay does not make the associated UI read-only.

Expected result

The ReadOnly state should be reflected by the property editor.

[nul800sebastiaan]

Hi @harry-gordon - thanks for the report. As problem solvers, we love thinking of solutions.. but I'd like to hear a bit more about the problem you're trying to solve, what is the use case for marking properties as readonly and who does it benefit?

From a quick look in the source code, the purpose is not to make the property not-editable but to prevent changes from being saved: https://github.com/umbraco/Umbraco-CMS/blob/v8/contrib/src/Umbraco.Web/Models/Mapping/MemberTabsAndPropertiesMapper.cs#L197

[harry-gordon]

Hi @nul800sebastiaan, good question! My use case is that I want some properties to be read-only under certain circumstances, specifically I've added a "locking" mechanism for some parts of the tree which prevents changes being saved. Currently when a user attempts to save those locked nodes they get an error but I'd like to make the properties on those nodes visibly "read-only" with fields being greyed out.

I realise that the current read-only implementation doesn't seem to be targeted at the UI but is it not quite strange to have a property that is read-only but can still be edited in the UI? I nearly filed this as a feature request but since the current behaviour could be confusing for users I've made it a bug 🐛. Happy for you to switch it to feature request though, I'm guessing it is a considerable effort to make all property editors support a read-only state!

Does that all make sense? Happy for any suggestions as to how else I can achieve read-only nodes/properties for my editors.

[umbrabot]

Hiya @harry-gordon,

Just wanted to let you know that we noticed that this issue got a bit stale and might not be relevant any more.

We will close this issue for now but we're happy to open it up again if you think it's still relevant (for example: it's a feature request that's not yet implemented, or it's a bug that's not yet been fixed).

To open it this issue up again, you can write @umbrabot still relevant in a new comment as the first line. It would be super helpful for us if on the next line you could let us know why you think it's still relevant.

For example:

@umbrabot still relevant
This bug can still be reproduced in version x.y.z

This will reopen the issue in the next few hours.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂