Itempicker: Add back missing filter in template picker #9132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @BatJan! Thanks for the PR. We'll take a look and shout if we need anything. Happy Hacktoberfest! Em |
nul800sebastiaan
added
community/pr
type/bug
hacktoberfest/contrib-2020
release/8.10.0
and removed
community/pr
type/bug
labels
nul800sebastiaan
changed the title
nul800sebastiaan
added
release/8.8.1
status/regression
and removed
release/8.10.0
labels
|
This broke in v8.8.0, have cherry picked for 8.8.1 (and higher versions) in 7d3df87 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
@nul800sebastiaan This PR fixes the issue where the search filter was not being displayed when used in the "template" context - Since the model is not immutable it's not enough to assume that the filter should be displayed or hidden if model.filter is true or false since it can also be undefined. Therefore it's now changed from
ng-if="model.filter"tong-if="model.filter !== false👍Before
After
