Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V9: Removed manic from greetings #12514

Merged
merged 1 commit into from Jun 1, 2022
Merged

Conversation

lassefredslund
Copy link
Contributor

Removed manic from greetings

@nikolajlauridsen nikolajlauridsen merged commit 57babbe into v9/9.5 Jun 1, 2022
@nikolajlauridsen nikolajlauridsen deleted the v9/bugfix/fix-greeting branch June 1, 2022 12:28
@leekelleher
Copy link
Member

@lassefredslund I applaud the replacement for positive language. 👍
(Although noting for context that the original was a joke on The Bangles song - in the spirit of Umbraco's 6.13% crazy 😝)

Taking a cursory look at the other language files, I noticed the following - running them through Google Translate...

I'm not an expert in those languages and wouldn't feel confident altering these localizations and submitting a pull request for them.

@simonech
Copy link
Contributor

simonech commented Jun 3, 2022

I kind hate that the "cancel culture" is affecting Umbraco...
I wish you focused on fixing issues that really matter instead

@lassefredslund
Copy link
Contributor Author

Thanks @leekelleher and @simonech for your comments and yes, I’m fully aware that there is a history around a word like this and that this funny/loose/crazy approach is part of how we like to communicate (and which I found appealing myself when I first discovered Umbraco back in 2008).
In this case, we’ve been contacted by users who have a mental illness close to them and I found it respectful to change this word – and believe we fixed something that really matters to someone.

@simonech
Copy link
Contributor

simonech commented Jun 3, 2022 via email

@simonech
Copy link
Contributor

simonech commented Jun 3, 2022 via email

@c9mb
Copy link

c9mb commented Jun 3, 2022

@simontech - Sorry, but I don't understand why changes acknowledging and eliminating offense/disrespect/hurt to others are labeled as 'cancel culture'. For me, the question should never be one of 'why change?' but rather one of 'why not change?'.

@simonech
Copy link
Contributor

simonech commented Jun 4, 2022

@simontech - Sorry, but I don't understand why changes acknowledging and eliminating offense/disrespect/hurt to others are labeled as 'cancel culture'. For me, the question should never be one of 'why change?' but rather one of 'why not change?'.

I'm hurt that the reference to the '80s song and that reminds memories of my youth and that many of editors find amusing had been removed.
I don't see why Manic Monday would offend someone.

Then why not remove "thunderous Thursday" if someone complains they are afraid of thunders? Or "tubular Tuesday" since now tubular tyres in bikes are a thing of the past and I get shivering down my spine just thinking of the pain they caused to my poor hands in the past?

Considering that these greetings can be customised by users, I'd not change the Umbraco cultural references but point people to how they can change it themselves.
https://our.umbraco.com/Documentation/Fundamentals/Backoffice/Login/

@c9mb
Copy link

c9mb commented Jun 4, 2022

I'm not offended by much, but I also don't care if someone is and asks for change - if change doesn't cause me a problem, and it removes one for someone else, then why not.

Personally, I find the whole 'friendly' thing a bit cringe-worthy - it's CMS software not a best-friends chat-site - and if it were my choice, I'd just remove the defaults entirely, and leave them as optional.

@simonech
Copy link
Contributor

simonech commented Jun 4, 2022

@c9mb that could have made better sense as PR than removing the default old greeting that has a whole story behind it.
I guess I'll make a PR to make the "friendly" greeting as optional (or on by default with possibility to disable them)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants