Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

U4-11149 fixed error when creating new xslt file #2540

Merged
merged 2 commits into from Apr 9, 2018
Merged

U4-11149 fixed error when creating new xslt file #2540

merged 2 commits into from Apr 9, 2018

Conversation

dawoe
Copy link
Contributor

@dawoe dawoe commented Mar 24, 2018

Prerequisites

Description

The create task was missing in the UI.xml file. Added it back now it works

@dawoe
Copy link
Contributor Author

dawoe commented Mar 27, 2018

I just noticed this also when trying to create a new member group with the latest dev-v7 branch.
So maybe it has deeper underlying cause.

I see last commits in LegacyDialogHandler are done by @Shazwazza

Maybe he has an idea what is the cause ?

@dawoe
Copy link
Contributor Author

dawoe commented Mar 27, 2018

The member groups not working is related to this commit by 0d2df4d by @RobertCopilau

It changed the namespace of MemberGroupsTask class

@nul800sebastiaan should i fix in this PR or should i create a seperate one ?

@dawoe
Copy link
Contributor Author

dawoe commented Mar 27, 2018

Fixed the issue with membergroups in a seperate PR : #2545

@dawoe dawoe changed the title U4-10659 fixed error when creating new xslt file U4-11149 fixed error when creating new xslt file Apr 6, 2018
@nul800sebastiaan
Copy link
Member

This actually should be fixed in UI.Release.xml, which is the one we use when building Umbraco. I have no idea how this ever could have worked, doesn't seem like this part of the file has changed a lot in the last few years.

@dawoe
Copy link
Contributor Author

dawoe commented Apr 9, 2018

I added it to the release.xml as well.

There have been some changes in the code that handles this. But could not track it down. Maybe it's because there are 2 node types in the xml to handle xslt files. One with alias initXslt and one with alias xslt

Dave

@nul800sebastiaan
Copy link
Member

Cool! I'll merge it, not sure what happened but it seems like it hasn't worked for a long time.

I actually thought we were just hiding the XSLT tree if there was not files in the XSLT folder on disk :-)

@nul800sebastiaan nul800sebastiaan merged commit 07fc675 into umbraco:dev-v7 Apr 9, 2018
@dawoe dawoe deleted the temp-U4-11149 branch April 9, 2018 12:04
nul800sebastiaan pushed a commit that referenced this pull request Apr 9, 2018
* U4-10659 added create task back for xslt files

* Add fix to UI.Release.xml as well
nul800sebastiaan pushed a commit that referenced this pull request Apr 9, 2018
* U4-10659 added create task back for xslt files

* Add fix to UI.Release.xml as well
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants