U4-11253 New Chrome 66 trimStart function is overriding the Umbraco C…

[nul800sebastiaan]

…ore trimStart polyfill

Prerequisites

• I have written a descriptive pull-request title
• I have linked this PR to an issue on the tracker at http://issues.umbraco.org

Description

Re: http://issues.umbraco.org/issue/U4-11253

By ALWAYS overriding the trimStart and trimEnd method we are not affected by the change to Chrome 66 which implements these methods without the ability to remove a specific character.

[JimBobSquarePants]

Noooooooooooooo!!!!!!!! This is such a terrible idea. You’ve just been broken every potential bit of third party code that would rely on the native implementation.

[nul800sebastiaan]

Okay, calm down. We need a temporary fix for now, we're evaluating a long term fix later.

[Shazwazza]

we can make both implementations still work. Based on this https://developers.google.com/web/updates/2018/04/nic66 , all these new methods do is trim whitespace and they don't accept any params. Our methods DO accept params. So all we need to do is:

• When Extensions.js loads, check if these methods exist, if they do, we store the original function reference but we still replace these methods
• When these methods are called and there are no parameters specified and we have a reference to the original function, we'll call it without any params

[jesperordrup]

We need a temporary fix for now, we're evaluating a long term fix later.

We've just discovered a conflict with a third party plugin we use in Umbraco Backends. Its called Small.Chat. WHen we load smallchat then it overrides trimStart and then Umbraco fails.

While I think Small.Chat shouldnt override anything - it shows that there might be something that needs to be fixed?