New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing new colour picker for document types #2792

Merged
merged 3 commits into from Jul 26, 2018

Conversation

Projects
None yet
3 participants
@OwainWilliams
Contributor

OwainWilliams commented Jul 25, 2018

Changing the dropdown menu for a colour swatch picker

Prerequisites

  • I have written a descriptive pull-request title
  • I have linked this PR to an issue on the tracker at http://issues.umbraco.org

Description

Remove the dropdown menu of colours from the Document Type icon selector and replace it with a colour swatch option.

http://issues.umbraco.org/issue/U4-11168

Implementing new colour picker for document types
Changing the dropdown menu for a colour swatch picker
@OwainWilliams

This comment has been minimized.

Contributor

OwainWilliams commented Jul 25, 2018

A known issue which I need help with is, the colour swatches are not showing their colour. However, when I click on the swatches, the colours do change the icons. So everything works, it's just the colours dont show just now.

image

@bjarnef

This comment has been minimized.

Contributor

bjarnef commented Jul 25, 2018

@OwainWilliams

This comment has been minimized.

Contributor

OwainWilliams commented Jul 25, 2018

Because the last time I did that I broke my PR 😊 once it's merged you're more than welcome to create your own PR and make it a directive.

@bjarnef bjarnef referenced this pull request Jul 25, 2018

Closed

Add color swatches directive #2793

2 of 2 tasks complete
@bjarnef

This comment has been minimized.

Contributor

bjarnef commented Jul 25, 2018

I think it would be easier to work on the same PR to contribute, but I have submitted a new PR, which introduce an directive instead.

OwainWilliams and others added some commits Jul 26, 2018

Changing the colours to variables
Changing all the colours used in the colour swatches to variables and refactoring the css to make it a bit easier to read. 
Also adding the background-color value as this was missing.

@wafflebot wafflebot bot added the review label Jul 26, 2018

@nul800sebastiaan nul800sebastiaan merged commit 0eddf6b into umbraco:dev-v7 Jul 26, 2018

1 check was pending

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details

@wafflebot wafflebot bot removed the review label Jul 26, 2018

@nul800sebastiaan

This comment has been minimized.

Member

nul800sebastiaan commented Jul 26, 2018

🎉 🏅 Merged!

So I've taken the additional changes @bjarnef put in his PR to turn the swatches into a directive as well, without making the mess that this accidentally caused in the first place.

Thanks again @OwainWilliams for hanging in there. Love this new way of selecting colors, it's much much nicer than a drop down! 👍 💯

Thanks very much @bjarnef for the help here as well!

@OwainWilliams And.. of course you now have a shiny Contributor badge on Our! 💪 https://our.umbraco.com/member/144571

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment