Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3102 - Make styling for media search dialogue prettier #3103

Merged
merged 2 commits into from Oct 3, 2018
Merged

#3102 - Make styling for media search dialogue prettier #3103

merged 2 commits into from Oct 3, 2018

Conversation

BatJan
Copy link
Contributor

@BatJan BatJan commented Oct 1, 2018

Prerequisites

Description

I changed the default checkbox input to be using the umbToggle directive and added a little spacing around the block so it does not look so cramped.

This is what it looks like now

prettier-toggle

@KimHolzmann
Copy link
Contributor

👍

@abjerner
Copy link
Contributor

abjerner commented Oct 1, 2018

Awesome Jan. Thanks for submitting a PR for this 👍

I will try giving it a spin, and report back if I find anything.

Now you just need four more PRs https://hacktoberfest.digitalocean.com/stats/BatJan ;)

@BatJan
Copy link
Contributor Author

BatJan commented Oct 2, 2018

@abjerner Awesome - Haha, don't you worry. I'll get there :) Wedding and vacation done, back in business 😄

@nul800sebastiaan nul800sebastiaan merged commit 125bbdd into umbraco:dev-v7 Oct 3, 2018
@nul800sebastiaan
Copy link
Member

Wonderful, looks much better! 👍 Thanks @BatJan !

image

@KimHolzmann
Copy link
Contributor

👍

@nul800sebastiaan
Copy link
Member

Hi there @BatJan,

First of all: A big #H5YR for contributing to Umbraco during Hacktoberfest! We are very thankful for the huge amount of PRs submitted, and all the amazing work you've been doing 🙏

If you haven't heard already we have had a record breaking amount of PR's in both the CMS and the Documentation repository. You can read all about the numbers in the Umbraco Hacktoberfest Aftermath blog post.

In the spirit of Hacktoberfest we've prepared some exclusive Umbraco swag for all our contributors - including you!

Receive your swag! 👈 Please follow this link to fill out and submit the form, before November 21st 2018.

Following this date we'll be sending out all the swag, which also means that it might not reach your doorstep before December, so please bear with us and be patient 🙏

The only thing left to say is thank you so much for participating in Hacktoberfest! We really appreciate the help!

Kind regards,
The Umbraco PR Team & The Documentation Curators

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants