New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix publish dates issues #3507

Merged
merged 3 commits into from Dec 3, 2018

Conversation

Projects
None yet
7 participants
@kjac
Copy link
Contributor

kjac commented Nov 4, 2018

Prerequisites

  • I have added steps to test this contribution in the description below

If there's an existing issue for this PR then this fixes: #2905 and #3267

Description

This PR fixes two things concerning the "Save and publish" button:

  1. The default action remains "Save and publish" even if an expiry date is set (as outlined in both #2905 and #3267). The default action only changes to "Save and schedule" when a publish date is set.
  2. The notifications from the server now contain the release or expiry dates (as outlined in #2905).

To test the PR, simply apply release and expiry dates to various pieces of content and verify that the
"Save and publish" button and the notifications behave as it is so nicely outlined in #2905.

Here's how it looks when an expiry date is set:

save and publish with expire date

...and here's how it looks with a release date set:

save and publish with release date

I have added translations for en-GB, en-US and da-DK.

@emmaburstow

This comment has been minimized.

Copy link
Contributor

emmaburstow commented Nov 8, 2018

Got this :)

Em

@emmaburstow
Copy link
Contributor

emmaburstow left a comment

Once again, lovely work. This works as advertised. It's a change I really like too.

@kjac

This comment has been minimized.

Copy link
Contributor

kjac commented Nov 8, 2018

Yeah it makes good sense 😄

@cloudweb13

This comment has been minimized.

Copy link

cloudweb13 commented Dec 1, 2018

@emmaburstow when does this fix will be available in Umbraco. Our clients are asking about this and I'd like to give feedback.

@emmaburstow

This comment has been minimized.

Copy link
Contributor

emmaburstow commented Dec 3, 2018

Hi @cloudweb13

I can't say for sure but perhaps @nul800sebastiaan can?

Em

@sussexrick

This comment has been minimized.

Copy link

sussexrick commented Dec 3, 2018

We're really keen to see this too @nul800sebastiaan. We use expiry dates on almost everything and we have a large pool of inexperienced users so we see this usability issue as a block to upgrading to anything beyond Umbraco 7.7 (and by extension, Forms 6.x).

kjac and others added some commits Nov 4, 2018

Make the default action "save and publish" when an expiry date is set…
… (unless a release date is set too, of course)

@umbracoci umbracoci force-pushed the kjac:fix-publish-dates-issues branch from 4a0f270 to 2c34cb4 Dec 3, 2018

@nul800sebastiaan nul800sebastiaan merged commit 9ad69c1 into umbraco:dev-v7 Dec 3, 2018

0 of 2 checks passed

Cms Continuous in progress
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
@nul800sebastiaan

This comment has been minimized.

Copy link
Member

nul800sebastiaan commented Dec 3, 2018

Thanks @kjac - I also added the publish time to the notification!

@kjac kjac deleted the kjac:fix-publish-dates-issues branch Dec 3, 2018

@kjac kjac referenced this pull request Dec 7, 2018

Merged

Fix edit content localization errors #3840

1 of 1 task complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment