Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Spanish translations #3742

Merged
merged 2 commits into from Nov 27, 2018

Conversation

Projects
None yet
3 participants
@gdiazderadaa
Copy link
Contributor

commented Nov 22, 2018

Prerequisites

  • I have added steps to test this contribution in the description below

If there's an existing issue for this PR then this fixes:

Description

@poornimanayar

This comment has been minimized.

Copy link
Contributor

commented Nov 23, 2018

Thanks a lot for this @gdiazderadaa. Happy to approve this. Do you have a Our Umbraco Profile? Please let us know here so that you can get your badge.

Poornima

@poornimanayar
Copy link
Contributor

left a comment

Thanks for the quick fix @gdiazderadaa . My Spanish could be

@gdiazderadaa

This comment has been minimized.

Copy link
Contributor Author

commented Nov 23, 2018

Thanks a lot for this @gdiazderadaa. Happy to approve this. Do you have a Our Umbraco Profile? Please let us know here so that you can get your badge.

Poornima

Hey Poornima, no worries at all, happy to contribute! I just created my umbraco profile: https://our.umbraco.com/member/275977

Thanks!

PS: Had closed the PR by mistake!

@gdiazderadaa

This comment has been minimized.

Copy link
Contributor Author

commented Nov 26, 2018

Hi @poornimanayar, can see this hasn't been merged yet. Is there anything else I have to do? Thanks

@poornimanayar

This comment has been minimized.

Copy link
Contributor

commented Nov 26, 2018

Hi @gdiazderadaa ,

No you dont need to do anything. Once it is approved by one of us it can usually take a couple of days before it actually gets merged into the latest dev branch. Please bear with us till that is done. Its all good otherwise. :-)

I would highly recommend you creating a Our profile and linking your github account as well to your profile so that when it gets to the point of merge you can have your C-Trib badge.

Regards,
Poornima

@nul800sebastiaan nul800sebastiaan changed the title Updated with more accurate translations Updated Spanish translations Nov 27, 2018

@nul800sebastiaan nul800sebastiaan merged commit d1457cf into umbraco:dev-v7 Nov 27, 2018

0 of 2 checks passed

Cms Continuous #201811230002 failed
Details
continuous-integration/appveyor/pr AppVeyor build failed
Details
@nul800sebastiaan

This comment has been minimized.

Copy link
Member

commented Nov 27, 2018

Thanks very much @gdiazderadaa and congratulations with the contribution badge on your Our Umbraco profile! https://our.umbraco.com/members/id:275977/ 🏅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.