Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove/Replace endPreview.aspx with MVC endpoint #3884

Merged

Conversation

Projects
None yet
3 participants
@tristanjthompson
Copy link
Contributor

tristanjthompson commented Dec 14, 2018

Prerequisites

  • I have added steps to test this contribution in the description below

Description

V8 Hackathon PR - https://trello.com/c/j47VNapS/87-rewrite-remove-umbracowebui-umbraco-endpreviewaspx
Copied the code from endPreview.aspx.cs into a new End action in the existing PreviewController. I did some slight refactoring of the code after a peer review (inverting an if condition).

All instances of endPreview.aspx in the project have been replaced with the new route to preview/end. There was a unit test ('PreviewBadge') which referenced the url which has also been modified and still passes.

To test, I went through the process of previewing a change to a document and cancelling the preview in 2 different ways:

  • In the preview page (with options to preview in different devices), I tested by clicking the X button to close preview
  • When navigating the site in preview mode, clicking the preview banner should end preview. It still does.
  • Verified that if you're previewing a sub-page and click the banner to end preview, that the redirect back to the same page still works.
@emmaburstow

This comment has been minimized.

Copy link
Contributor

emmaburstow commented Dec 15, 2018

Hi @tristanjthompson

As before, we'll take a look and let you know if we need you to do anything.

Thanks for your hard work!

Emma, Pull Request team

@nul800sebastiaan nul800sebastiaan merged commit 65f7e44 into umbraco:temp8 Dec 19, 2018

@nul800sebastiaan

This comment has been minimized.

Copy link
Member

nul800sebastiaan commented Dec 19, 2018

Sweet, thanks very much @tristanjthompson !

Congrats on your first merged PR for Umbraco CMS, well done!! 👍👍

And look at that shiny new contributor badge on your profile https://our.umbraco.com/members/id:11255/ 🏅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.