Add null checking for translation details #4009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tranquan
changed the title
tranquan
changed the title
|
Hi @tranquan Thanks ever so much for your pull request and congrats on your first one for this repo! We'll have a look at the code, test behaviour and let you know if we need you to make any changes. If not, and we're happy with the change, we'll merge it and you'll get a shiny contributor badge on your our.umbraco.com profile. Emma, Pull Request team |
src/Umbraco.Web/umbraco.presentation/umbraco/translation/details.aspx.cs
Outdated
Show resolved
Hide resolved
|
Thanks, good update! 👍 Congrats on your first accepted pull request to Umbraco CMS, well done! You've earned yourself that much coveted contributor badge on our Umbraco 🎉 https://our.umbraco.com/members/tranquan221b |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
If there's an existing issue for this PR then this fixes:
Description
umbraco.presentation/umbraco/details.cs