Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
V8: UI — updated login screen #4754
@nielslyngsoe it seems this change removes the option to set a custom background image on login screen introduced introduced in Umbraco v7.6
We use this for some of our clients and it feels a bit more as their own, while still keeping the Umbraco branding.
Mar 11, 2019
1 check was pending
This way, the overlay div is always rendered (even when the
Well not quite, as an empty value could cause the current page to be requested again:
And exactly like you say, why force a background-image if you don't want one, but then include a fallback in the default styles?
I guess the background image just can be set from the controller and remove the hardcoded css background image.
and then only render the overlay if
Maybe with some basic validation or the path to the login background image is valid before assigning the value to
Gentlemen, I think your feedback is wonderful and I appreciate the engagement but can we please be pragmatic: