Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid removing a public method (used by forms 8.0.0) #5002

Merged

Conversation

@bergmania
Copy link
Member

commented Mar 18, 2019

Avoid introducing a breaking change that would break the compatibility for forms 8.0.0.

Re-introduce the method used by forms as obsolete. And re-name the new method.

Test:

  • Install forms 8.0.0
    • Before this fix Umbraco would not start

@ghost ghost assigned bergmania Mar 18, 2019

@bergmania bergmania removed their assignment Mar 18, 2019

@bergmania

This comment has been minimized.

Copy link
Member Author

commented Mar 18, 2019

NOTE: This fix is important before the next release based on dev-v8 otherwise we introduce a breaking change!

@warrenbuckley warrenbuckley merged commit 51be2a5 into dev-v8 Mar 18, 2019

1 check was pending

Cms 8 Continuous in progress
Details

@warrenbuckley warrenbuckley deleted the v8/bugfix/avoid-breaking-change-in-dashboard-events branch Mar 18, 2019

@ghost ghost removed the state/review label Mar 18, 2019

@marcemarc

This comment has been minimized.

Copy link
Contributor

commented on 44beb81 Mar 19, 2019

@bergmania Would SendingDashboardSlimModel be a more appropriate re-name for this event? for developers subscribing to this event, the V2 bit won't have any context... and will seem strange... ?

This comment has been minimized.

Copy link
Member Author

replied Mar 20, 2019

@marcemarc, thanks for suggesting. I have updated the code here 64bc0cf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.