Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V7: Log correct user ID when emptying the content recycle bin #5054

Merged

Conversation

@kjac
Copy link
Contributor

commented Mar 24, 2019

Prerequisites

  • I have added steps to test this contribution in the description below

Description

The user ID is currently hardcoded to "0" when emptying the recycle bin. This PR ensures that the correct user ID is logged:

image

Note: For backwards compatibility I have added explicit overloads to EmptyRecycleBin in both the content service interface and implementation. The current method (without user ID) has been marked as obsolete.

Testing this PR

  1. Log in as another user than the admin
  2. Empty the content recycle bin
  3. Verify that the correct user ID is logged in the umbracoLog table
kjac added 2 commits Mar 24, 2019
@poornimanayar

This comment has been minimized.

Copy link
Contributor

commented Mar 25, 2019

Morning Kenn,

Lets test this and get back to you!

Poornima

@zpqrtbnk zpqrtbnk changed the base branch from dev-v7 to v7/dev Mar 31, 2019

@nul800sebastiaan nul800sebastiaan merged commit 2c32fab into umbraco:v7/dev Apr 17, 2019

1 check passed

Cms 7 Continuous #201903310006 succeeded
Details
@nul800sebastiaan

This comment has been minimized.

Copy link
Member

commented Apr 17, 2019

Lovely, thanks Kenn!

@kjac kjac deleted the kjac:fix-content-empty-trash-audit-user branch Apr 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.