Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make XmlHelper class public again #5138

Merged
merged 2 commits into from Apr 4, 2019

Conversation

@Jeavon
Copy link
Contributor

commented Apr 3, 2019

This class is used a lot by package installers in v7 and should be available for use in v8 packages

@ghost ghost assigned Jeavon Apr 3, 2019

@Shazwazza

This comment has been minimized.

Copy link
Member

commented Apr 4, 2019

We would need a couple additional changes for this since there are some methods in there that will need to be changed to internal that we wish to not support publicly:

  • GetAttributesFromElement
  • Split
  • GetNodeValue
@Jeavon

This comment has been minimized.

Copy link
Contributor Author

commented Apr 4, 2019

@Shazwazza updated accordingly, thanks!

@Shazwazza Shazwazza merged commit 3505984 into umbraco:v8/dev Apr 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.