Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

V8: Fix broken listview pagination when using the back link #5149

Merged
merged 3 commits into from Apr 22, 2019

Conversation

@kjac
Copy link
Contributor

commented Apr 4, 2019

Prerequisites

  • I have added steps to test this contribution in the description below

Description

When a listview is paginated, the back link always returns to page 1:

image

This happens because we don't use editPath of the items in the list when opening them for editing (unless they're opened in a new window), thus discarding the pagination info needed when returning to the list.

The issue applies both to the "list" and "card" layout of listviews.

With this PR applied, the back link behaves as expected:

listview-back-pagination

As an added bonus the PR gets rid of a few of the hardcoded edit entity paths 馃槃

@emmaburstow

This comment has been minimized.

Copy link
Contributor

commented Apr 11, 2019

Hey @kjac

Thanks for the work. We'll let you know if we need anything,

Em

@nul800sebastiaan nul800sebastiaan merged commit e180bb6 into umbraco:v8/dev Apr 22, 2019

@nul800sebastiaan

This comment has been minimized.

Copy link
Member

commented Apr 22, 2019

Much better, thanks!

@ghost ghost removed the state/backlog label Apr 22, 2019

@kjac kjac deleted the kjac:v8-fix-listview-pagination branch Apr 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can鈥檛 perform that action at this time.