Fix for U4-5719 U7.2 - mediaPickerDialog broken for data type prevalues #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -58,7 +58,11 @@ function mediaPickerController($scope, dialogService, entityResource, $log, icon | |||
|
|
|||
| //load media data | |||
| var modelIds = $scope.model.value ? $scope.model.value.split(',') : []; | |||
| entityResource.getByIds(modelIds, $scope.cfg.entityType).then(function (data) { | |||
| var entityType = "Media"; | |||
| if (!$scope.cfg === undefined) { | |||
There was a problem hiding this comment.
I don't think this is required. Half the point of the other changes was to get rid of the silly $scope.cfg stuff which was totally useless and confusing. There is no $scope.cfg anymore anywhere. Since this is just a media picker, the entityType will always be media.
There was a problem hiding this comment.
I must have just missed the $scope.cfg reference. Anyways, i'll have a look and pull this in shortly.
|
I did wonder what it was there for but didn't know if it was used somewhere with $scope.cfg, I have updated to PR to just fix to "Media" now. Thanks! |
|
@Shandem is this ok now? |
|
Sorry, have been away need to check! |
|
@Shazwazza this is still broken in 7.2-beta2, any update? |
|
Yes, seems to be fixed now, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.