Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GetById(Udi) to published caches #5246

Merged
merged 1 commit into from Apr 16, 2019

Conversation

@zpqrtbnk
Copy link
Contributor

commented Apr 12, 2019

See #5216 - issue has been fixed, was adressing v7, and this is adressing v8.

@ghost ghost assigned zpqrtbnk Apr 12, 2019

@zpqrtbnk zpqrtbnk removed their assignment Apr 12, 2019

@Shazwazza Shazwazza merged commit 9f9d24e into v8/dev Apr 16, 2019

1 check passed

Cms 8 Continuous #2929 succeeded
Details

@ghost ghost removed the state/review label Apr 16, 2019

@Shazwazza

This comment has been minimized.

Copy link
Member

commented Apr 16, 2019

Looks good, have added as 'breaking' only because we've added some methods to a public interface at the caching level.

@Shazwazza

This comment has been minimized.

Copy link
Member

commented Apr 16, 2019

(not sure why it's not letting me delete this branch though)

@zpqrtbnk zpqrtbnk deleted the v8/bugfix/5216-cache-getbyudi branch Apr 16, 2019

@zpqrtbnk

This comment has been minimized.

Copy link
Contributor Author

commented Apr 16, 2019

about branch deletion: because GitHub branch protection rules don't work as... expected - if a branch is protected, one cannot delete it anymore - have de-activated some rules, and deleted the branch - will figure it out

@KevinJump

This comment has been minimized.

Copy link
Contributor

commented Jun 11, 2019

Is this the fix to

#4407 - v8: ContentService.GetById gets cached version when using Key (Guid)
& #2997 - ContentService returns outdated result

?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.