Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #5257: Added overloads for retrieving image crop URLs via culture, segment and fallback method #5258

Open

Conversation

Projects
None yet
2 participants
@AndyButland
Copy link
Contributor

commented Apr 14, 2019

In this PR have added overloads and made a small amend to the method for retrieving a crop URL to support culture, segment (when used) and fall-back method.

Issue: #5257
Forum discussion here.

To test you should find a calls like this in the view will respect the culture and fallback parameters (where the property testImage is of type "Image Cropper"):

<img src="@Url.GetCropUrl(Model, propertyAlias: "testImage", height: 300, width: 300)" />
<img src="@Url.GetCropUrl(Model, propertyAlias: "testImage", culture: "es", height: 300, width: 300)" />
<img src="@Url.GetCropUrl(Model, propertyAlias: "testImage", culture: "it", fallback: Fallback.ToLanguage, height: 300, width: 300)" />
@emmaburstow

This comment has been minimized.

Copy link
Contributor

commented Apr 16, 2019

Hiya @AndyButland

Thanks for the work, this looks ace. One of us will take a good look and let you know if we need anything from you :)

Em

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.