Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-adding outline to the umb-button__button for focus states #5320

Merged
merged 2 commits into from Apr 24, 2019

Conversation

@shane-sigma
Copy link
Contributor

commented Apr 23, 2019

Prerequisites

This is in relation to the accessibility issues on ticket #5277 - Bug number 4 from the table

Description

Bottom publishing options ('Preview', 'Save', 'Save and publish') have insufficient focus (tab) state

I have removed the CSS that prevented the browser default outline from showing on these buttons

Screen Shot 2019-04-23 at 14 36 22

@poornimanayar

This comment has been minimized.

Copy link
Contributor

commented Apr 23, 2019

Hey @shane-sigma ,

Congratulations on your first PR! We shall review it and get back to you if we need anything more. Once this PR gets approved and merged you will have your shiny Contributor badge on your Our.Umbraco profile. 👍

Poornima

@warrenbuckley
Copy link
Member

left a comment

Change looks fine @shane-sigma 💪
I will just update/revert the change to the gitignore file as there should not be a web.config file in that folder/location anyway

@ghost ghost assigned warrenbuckley Apr 24, 2019

@warrenbuckley warrenbuckley merged commit c21b740 into umbraco:v8/dev Apr 24, 2019

1 check passed

Cms 8 Continuous #3070 succeeded
Details

@ghost ghost removed the state/review label Apr 24, 2019

@warrenbuckley warrenbuckley removed their assignment Apr 24, 2019

@shane-sigma shane-sigma deleted the shane-sigma:temp-5277-4 branch Apr 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.