Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V8: Add ability to resolve Health Checks with other property types - e.g. Content Picker #5652

Open
wants to merge 7 commits into
base: v8/dev
from

Conversation

Projects
None yet
3 participants
@alanmac
Copy link
Contributor

commented Jun 12, 2019

Link to existing issue: #5452

DESCRIPTION:

This PR does a couple of things:

  • Allows for using a new type of property editor (Content Picker) to resolve a Health Check
  • Allows specifying a 'MissingErrorMessage' property within a Health Check that will display if a setting does not exist within a config file.

I've added the ability to use a Content Picker to resolve a Health Check because I want to add a Privacy Health Check that needs to verify that certain types of content items exist for a website. See gif below:

healthcheck

If the setting that a Health Check is looking for initially does not exist in the config file it will explain to the user that the config setting is missing and needs to be added:

config-setting-missing

TO TEST:

To test you can verify against the Privacy Health Check feature that is planned to be released as part of the Our Umbraco HealthChecks package, once the Core changes in this PR are merged.

  • Clone this PR & build the solution
  • Clone Our.Umbraco.HealthChecks from: https://github.com/alanmac/Our.Umbraco.HealthChecks/tree/feature/privacy-health-check
  • Reference the Umbraco.Web from this PR build within the Our.Umbraco.HealthChecks project - It needs to be aware of the Core changes made available with this PR.
  • Reference the Our.Umbraco.HealthChecks dll output from the Core project so that the Health Checks are loaded for you to test.
  • Copy App_Plugins/Our.Umbraco.HealthChecks from the Health Checks solution to the Umbraco Core solution so that the lang files are available.
  • Build and Run

There should now be a Privacy Health Check available within the Health Check Dashboard.

Initially when you run the check it should tell you that required App Settings are missing. Once you add those and run the check again, it should allow you to use a Content Picker to point to existing content nodes (you'll need to have those created also) to resolve the issue.

Thanks to @lssweatherhead for her collaboration on this Core change.

AndyButland and others added some commits Jun 1, 2019

Removed hard-coded email validation for healthcheck fix value.
Made validation for healthchcls more flexible, supporting none, email and regex.

(cherry picked from commit 2dfd490)
merge upstream remote
Merge remote-tracking branch 'upstream/v8/dev' into temp-5452-v8
refactor of healthcheck.controller.js based on @lssweatherhead sugges…
…tions

- added constant to better support new types of property editors
- code cleanup
added ability to set a message when a config value does not exist in …
…a file that it is expected in (MissingErrorMessage) - contributed by @lssweatherhead
@emmaburstow

This comment has been minimized.

Copy link
Contributor

commented Jun 18, 2019

Hi @alanmac

Thanks so much for the PR and also, for the brilliant documentation. Testing steps really help us to get these reviewed more easily. We'll let you know if we need anything from you and if not, we'll merge.

Thanks,

Emma

@alanmac

This comment has been minimized.

Copy link
Contributor Author

commented Jun 18, 2019

Hi @emmaburstow, that's great thanks. Looking forward to getting it merged!

Best,

Alan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.