Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V8: Custom IAntiForgeryAdditionalDataProvider implementation #5728

Merged
merged 1 commit into from Jun 26, 2019

Conversation

https://umbraco.visualstudio.com/D-Team%20Tracker/_workitems/edit/1085
…- Creates a custom IAntiForgeryAdditionalDataProvider that provides and validates custom token data in the request which allows having a custom AF token per form created with BeginUmbracoForm

@bergmania bergmania changed the title https://umbraco.visualstudio.com/D-Team%20Tracker/_workitems/edit/108… V8: https://umbraco.visualstudio.com/D-Team%20Tracker/_workitems/edit/108… Jun 26, 2019

@warrenbuckley

This comment has been minimized.

Copy link
Member

commented Jun 26, 2019

I have performed the same tests as the original V7 PR #5715

These all pass and are OK 👍

@warrenbuckley warrenbuckley merged commit 8831860 into v8/dev Jun 26, 2019

1 check passed

Cms 8 Continuous Build #3804 succeeded
Details

@warrenbuckley warrenbuckley deleted the v8/feature/AB-1085 branch Jun 26, 2019

@marcemarc

This comment has been minimized.

Copy link
Contributor

commented Jun 27, 2019

@bergmania scanning the repo each day to be aware of changes is something that people regularly do in the community, it would be 'super useful' if the titles of PRs reflected in some way the work involved, saves having to dig further in, and read through the actual code changes to keep on top of things... so something like
V8: Custom IAntiForgeryAdditionalDataProvider implementation

would be ace! - I can't link to umbraco.visualstudio.com tracker it is not open...

@bergmania bergmania changed the title V8: https://umbraco.visualstudio.com/D-Team%20Tracker/_workitems/edit/108… V8: Custom IAntiForgeryAdditionalDataProvider implementation Jun 27, 2019

@marcemarc

This comment has been minimized.

Copy link
Contributor

commented Jun 27, 2019

thanks @bergmania !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.