Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correcting ASCII art in README #6156

Merged
merged 2 commits into from Aug 29, 2019

Conversation

@callumbwhyte
Copy link
Contributor

commented Aug 20, 2019

During The past couple of NuGet updates I've done I noticed the README file shown doesn't contain @prjseal's wonderful ASCII Umbraco logo - so I've fixed it!

The kerning / spacing on the original art was bugging me slightly (I'm a sucker for detail...) so I've tweaked that too...

Hopefully this contribution is enough for my MVP status to be renewed next year 馃お

@abjerner

This comment has been minimized.

Copy link
Contributor

commented Aug 20, 2019

@callumbwhyte due to the complexity of this PR, have you considered creating a RFC first?

@callumbwhyte

This comment has been minimized.

Copy link
Contributor Author

commented Aug 20, 2019

Sorry @abjerner you are right... I will follow process next time and definitely submit an RFC first.

It's not the same, but I did do a Twitter poll and received a resounding yes!

Screenshot 2019-08-20 at 20 30 20

Copy link
Contributor

left a comment

Oh - my bad. This obviously changes things a lot...

B54TA1aiS9WSI-joaquin-phoenix

@nul800sebastiaan nul800sebastiaan merged commit a24e5bd into umbraco:v8/dev Aug 29, 2019
1 check passed
1 check passed
Cms 8 Continuous Build #4581 succeeded
Details
nul800sebastiaan added a commit that referenced this pull request Aug 29, 2019
(cherry picked from commit a24e5bd)
@nul800sebastiaan

This comment has been minimized.

Copy link
Member

commented Aug 29, 2019

AMAZING!

UMBAZING even 馃槀

Cherry picked for 8.1.4 563a352

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can鈥檛 perform that action at this time.