Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some accessibility misunderstandings #6342

Merged

Conversation

@BatJan
Copy link
Contributor

commented Sep 15, 2019

Prerequisites

  • I have added steps to test this contribution in the description below

Description

This PR fixes some accessibility misunderstandings on my part for some of PR's that has gotten accepted into the core already.

  1. The usage of aria-haspopup="dialog" will not make screen readers announce that a dialog will be visible currenlty - NVDA for instances will announce that it's a menu. So for now it's better to use the ellipsis convention. Therefore I have added a <span class="sr-only">...</span> after having a good chat with Florian Beijers about this. He suggested adding the text "(Opens dialog)" since the ellipsis approach is not used much on the web but mostly in software - But then we agreed that while "(Opens dialog)" would be nice it was less work to use the ellipsis since it does not require translation
  2. Which leads me to the next fix addressed in this PR - I removed the aria-hidden="true" attribute from the ellipsis since I realized that it's of course very relevant to have them announced letting screen reader users know that it will popup some kind of dialog - HQ got this correct from the start. #h5is 馃槃
BatJan added 2 commits Sep 15, 2019
鈥enu" currently. Instead add the ellipsis in a sr-only class
@nul800sebastiaan nul800sebastiaan merged commit 976465b into umbraco:v8/dev Sep 16, 2019
1 check passed
1 check passed
Cms 8 Continuous Build #5017 succeeded
Details
@nul800sebastiaan

This comment has been minimized.

Copy link
Member

commented Sep 16, 2019

Super, thanks @BatJan ! 猸愶笍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can鈥檛 perform that action at this time.