Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aria-live to let screen readers announce notifications #6406

Merged

Conversation

@BatJan
Copy link
Contributor

commented Sep 22, 2019

Prerequisites

  • I have added steps to test this contribution in the description below

This issue fixed no. 158 on the list of the Trello board (Added after the intital Github Issue #5277)

Description

Currently the notifications that appear whenever a content node, templates, document type etc. is saved is not announced by screen readers. which leaves screen reader users clueless that a status message telling us whether the save/publish was a success or not.

Therefore I have added aria-live="assertive" and aria-relevant="additions", which will make a screen reader prioritize announcing the latest added notification - So if 2 notifications are added quickly after each other it will abort reading the 1st status and start reading the 2 status instead.

I believe that some of the texts could be more meaningful not only in a non-visual context but also in a visual context but I think that is subject for another PR 馃槂

Looking forward to receive any questions or feedback you may have about this PR 馃憤

鈥s and a litle styling too
@nul800sebastiaan

This comment has been minimized.

Copy link
Member

commented Sep 22, 2019

Thanks Jan! :)

I'll have a look soon 馃憤

@BatJan

This comment has been minimized.

Copy link
Contributor Author

commented Sep 26, 2019

@nul800sebastiaan Any chance this will be reviewed during the Aarhus hackathon? 馃檹 馃槈

@nul800sebastiaan nul800sebastiaan merged commit e1d2860 into umbraco:v8/dev Sep 29, 2019
1 check passed
1 check passed
Cms 8 Continuous Build #5185 succeeded
Details
@nul800sebastiaan

This comment has been minimized.

Copy link
Member

commented Sep 29, 2019

Didn't make it, but will do now, sweet update @BatJan , thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can鈥檛 perform that action at this time.